tskit icon indicating copy to clipboard operation
tskit copied to clipboard

add_pbs

Open atongsa opened this issue 2 years ago • 3 comments

Description

sorry i messed and delete my local branch, so the pr #2749 was closed automately; i don't know how to reopen, so i opened a new pr; sorry agian;

Closes #2717

PR Checklist:

  • [ ] Tests that fully cover new/changed functionality.
  • [ ] Documentation including tutorial content if appropriate.
  • [ ] Changelogs, if there are API changes.

atongsa avatar Jul 06 '23 13:07 atongsa

I started commenting on the code, @atongsa, but noticed a bunch of typos, e.g.,

                            2 * (div=ersities[:, :, u] + diversities[:, :, v]) / denom

Please let us know when you've got code that runs (at least, doesn't have syntax errors)? Or, ask if you have specific questions about the approach?

petrelharp avatar Jul 06 '23 15:07 petrelharp

Hi @atongsa - are you planning to come back to this work? Thanks!

benjeffery avatar Sep 23 '24 11:09 benjeffery

sorry, it is a little difficult for me, i don't understand the errors, and has no idea how to fix it, i need to read more about the funcions and docs.

atongsa avatar Sep 30 '24 15:09 atongsa

Closing this for now due to inactivity.

benjeffery avatar Jan 07 '25 15:01 benjeffery

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.24%. Comparing base (3d4fc51) to head (2c96d74). Report is 212 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2777      +/-   ##
==========================================
- Coverage   89.83%   86.24%   -3.59%     
==========================================
  Files          30        8      -22     
  Lines       28624    13060   -15564     
  Branches     5590     2517    -3073     
==========================================
- Hits        25713    11264   -14449     
+ Misses       1655      991     -664     
+ Partials     1256      805     -451     
Flag Coverage Δ
c-tests 86.24% <ø> (ø)
lwt-tests ?
python-c-tests ?
python-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 23 files with indirect coverage changes

codecov[bot] avatar Jan 07 '25 15:01 codecov[bot]