tskit icon indicating copy to clipboard operation
tskit copied to clipboard

Improvement tskit treeseq from text mutations

Open lukashuebner opened this issue 2 years ago • 3 comments

Fixes #2729

lukashuebner avatar Apr 04 '23 09:04 lukashuebner

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.08%. Comparing base (72a7add) to head (5437546). Report is 133 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2734   +/-   ##
=======================================
  Coverage   94.08%   94.08%           
=======================================
  Files          29       29           
  Lines       28516    28516           
  Branches     1609     1609           
=======================================
  Hits        26828    26828           
  Misses       1653     1653           
  Partials       35       35           
Flag Coverage Δ
c-tests 92.36% <ø> (ø)
lwt-tests 89.05% <ø> (ø)
python-c-tests 70.89% <ø> (ø)
python-tests 99.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov[bot] avatar Apr 04 '23 09:04 codecov[bot]

Thanks for this @lukashuebner - I think @petrelharp has done basically the same thing in #2730. See the discussion over there for why we're a bit nervous about always computing the parents like this.

jeromekelleher avatar Apr 04 '23 10:04 jeromekelleher

Yes, thanks very much!

petrelharp avatar Apr 04 '23 15:04 petrelharp

Closing this a dupe of #2730

benjeffery avatar Sep 20 '24 15:09 benjeffery