msprime icon indicating copy to clipboard operation
msprime copied to clipboard

Test_pedigree.py with internal samples

Open abureau opened this issue 1 year ago • 1 comments

I have modified TestSimulateThroughPedigree and the simulate_pedigree function to specify generations of subjects as internal samples. Setting internal_sample_gen=[True, False] on line 562 specifies that founders i.e. parents of a two-generation pedigree are samples, but not their children (probands). This results in Fatal Python error: Aborted with core dump in my setup.

abureau avatar Oct 24 '24 17:10 abureau

I continue here the discussion of the closed pull request. I inserted the command tables.dump("test_shallow_internal.ts") at line 564 of test_pedigree.py. Then I called python3 algorithms.py --from-ts test_shallow_internal.ts 4 test.ts and got no error message. The tree object in the output test.ts seems fine, but I am not sure what to inspect.

No rush to reply, I just report now for later.

abureau avatar Oct 25 '24 14:10 abureau

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.23%. Comparing base (af5bd81) to head (78255b6). Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2326   +/-   ##
=======================================
  Coverage   91.23%   91.23%           
=======================================
  Files          20       20           
  Lines       11816    11816           
  Branches     2293     2293           
=======================================
  Hits        10780    10780           
  Misses        568      568           
  Partials      468      468           
Flag Coverage Δ
C 91.23% <ø> (ø)
python 98.68% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Jul 24 '25 15:07 codecov[bot]