tsctx

Results 25 comments of tsctx

https://github.com/nodejs/undici/blob/9dd11b8c61c95efd5459f375a196a117184230fa/lib/web/fetch/body.js#L297 This seems to be the cause. The difference with that is that it's happening because a reference isn't held.

@code-forger That appears to be a slightly different issue (as this is a request, not a response). I'd respectfully suggest creating a new issue for it. Ideally, it would be...

As an example, the 256Kib receive benchmark is 1.2x faster.

> Benchmarking websockets is hard and there is no benchmark to verify. It is a simple benchmark using console.time. For a correct benchmark, it should be a Parser-only benchmark.

This is a simple benchmark of the current Parser. - main ``` benchmark time (avg) (min … max) p75 p99 p999 ------------------------------------------------------------- ----------------------------- parsing 239 µs/iter (29'500 ns … 2'398...

@KhafraDev Would you be able to revisit this? This is the result of the #3203's of benchmarks. before / after ```shell > $ node ./benchmarks/websocket-benchmark.mjs (node:11148) [UNDICI-WSS] Warning: WebSocketStream is...

> Breaking Changes and Deprecations > None - This is a purely additive change that maintains full backward compatibility. All existing code will continue to work without modification. > Isn't...

@KhafraDev I kept the changes to a minimum. Is this okay?

@KhafraDev https://github.com/tsctx/undici/commit/06e14d93e8e20a5c09f3e5cf6f44df9c748fe133 (The change is not reflected in the PR, see here.) This PR objective is, avoid using the redundant operation `String.toWellFormed`. When the passed string is passed to the...