trynthink
AEO 2023 energy data updates
Update handling of AEO data files to fix double-counting of MELs and to report other fuel energy use (where other fuel includes residual oil, propane, steam from coal, motor gasoline, and kerosene).
Thanks @jtlangevin for the review. I'd already checked the energy values in the JSONs against the AEO microtables, and I addressed the required changes to ecm_prep.py that you identified in the revised commit. I then tested ecm_prep.py with a commercial other fuel ECM and ran into an unexpected issue. I'm interested in your thoughts on if and how it should be corrected.
When the other fuel ECM is processed, the ECM won't get an assigned lifetime, which then triggers an exception. ECM lifetimes are normally assigned to the life_meas variable here. Because other fuel data are only associated with the unspecified building type, at an earlier step, the ind iterator value is advanced to a value greater than 0, ensuring that the ECM lifetime is never assigned to life_meas.
I tested with the attached ECM definition. If you don't anticipate wanting to run scenarios that include ECMs like this, perhaps this problem doesn't need to be corrected.
Yes I see - the use of if ind == 0 in this section is causing problems in this case b/c when the building is unspecified the first index (pertaining to the new building vintage, which doesn't exist for unspecified) is skipped (per this section so none of those variables are initialized.
Let's improve the robustness of that initialization check. See new commit https://github.com/trynthink/scout/pull/398/commits/ee80fcd2ea32b5a55aae3ffe88f487417ecc7ff2, which works on your test ECM.
