OpenARC icon indicating copy to clipboard operation
OpenARC copied to clipboard

BUFRSZ too small truncating arc sig

Open nabbi opened this issue 3 years ago • 1 comments

Senders using MS Exchange / Outlook / M365 cloud hosted mail chains many headers together

The ARC-Message-Signature body as truncating at 1024 resulting in incomplete ARC headers

 ...
 X-MS-Exchange-CrossTenant-originalarrivaltime:
 X-MS-Exchange-CrossTenant-fromentityheader:
 X-MS-Exchange-CrossTenant-id:
 X-MS-Exchange-CrossTenant-

Unclear which BUFRSZ capped so doubled them all.

nabbi avatar Nov 14 '22 05:11 nabbi

Even if the issue is resolved by applying this PR, I don't think the cause of the issue is the value of BUFRSZ, but the wrong size estimation of (a) specific buffer(s). There are other macros for specifying buffer size, ARC_MAXHEADER (in libopenarc/arc.h) and MAXBUFRSZ (in libopenarc/openarc-internal.h and openarc/openarc.h).

I guess at least this one should be ARC_MAXHEADER + 1.

futatuki avatar Sep 17 '24 23:09 futatuki