http-server

http-server copied to clipboard

3rd argument in memcpy.

3

Hi, thank you for the great work. I've encountered a seg fault after registering a new uri. The issue seems to related to `memcpy` of `response_string`. I think the 3rd...

mikeliaohm

Hi, thank you for the great work. I have the issue as well. so i fixed. but when I merged, I saw your discussions [issue](https://github.com/trungams/http-server/issues/4). anyway, there is a risk...

jmu201621143028

Would you let me know which compiler I have to use?

7

Hi, Thanks for your good work. I'm really glad to see you and your project. I have tried to compile this project in Msys to cross-compile. But there is several...

youngelit0812

fixed 3rd argument in memcpy (w/ null terminator)

1

- Fix 3rd argument in memcpy to only copy the response string length or up to `kMaxBufferSize`. - Make sure `raw_response->buffer` is always null terminated.

mikeliaohm

Inside `HandleEpollEvent` function, Upon EPOLLOUT, if `EAGAIN/EWOULDBLOCK` occurs, the client fd is being readded to epoll list, but shouldn't it be just modified as done while doing `recv`? EPOLLOUT https://github.com/trungams/http-server/blob/1c171367234d245fa9a5452c86354681bbfe383c/src/http_server.cc#L206-L207...

PrashanthaTP