mint icon indicating copy to clipboard operation
mint copied to clipboard

Add detailed mod info view

Open jieyouxu opened this issue 2 years ago • 4 comments

Screenshot 2023-08-21 175451 Screenshot 2023-08-21 174831 Screenshot 2023-08-22 013756

Closes #83.

jieyouxu avatar Aug 21 '23 09:08 jieyouxu

Nice! Couple things:

  • Is it necessary to block interaction with the rest of the GUI when the details window is open? Changes to the profile don't invalidate any data displayed
  • Does the the window not play nicely with resizing? Would be nice if multiple detail windows could be opened simultaneously

trumank avatar Aug 21 '23 15:08 trumank

Nice! Couple things:

  • Is it necessary to block interaction with the rest of the GUI when the details window is open? Changes to the profile don't invalidate any data displayed
  • Does the the window not play nicely with resizing? Would be nice if multiple detail windows could be opened simultaneously

It's just that the current logic to handle the details window only correctly supports showing one mod detail at a time. EDIT: updated to support multiple mod detail windows.

jieyouxu avatar Aug 21 '23 17:08 jieyouxu

There is a major issue when resizing the details window as demonstrated in the video below:

https://github.com/trumank/drg-mod-integration/assets/84156063/2b7a438e-04a7-4824-a343-7a0710b02b03

There is also a fair bit of lag when moving the window around, though it's quite a minor thing and I wouldn't at all be bothered if it cannot be fixed easily.

Furthermore, basic markdown support would be nice. I know it's not in egui but I found this extension crate for it that kind of does it. EDIT: I just tried adding it for the description text, and it doesn't handle quote text line feed so well, it actually looks worse than without. So probably needs some extra work than just plug n play, if it's even worth it, since they can just click on the mod link to view it properly in browser anyway...

Buckminsterfullerene02 avatar Aug 22 '23 12:08 Buckminsterfullerene02

That looks like egui issue which I have no clue how to fix.

jieyouxu avatar Aug 22 '23 16:08 jieyouxu