manual-approval icon indicating copy to clipboard operation
manual-approval copied to clipboard

In a self-host-Runner environment, error retrieving approvers: error parsing exclude-workflow-initiator-as-approver flag: strconv.ParseBool: parsing "": invalid syntax An error will occur

Open jieey1140 opened this issue 3 years ago • 3 comments

The following error occurs.

error retrieving approvers: error parsing exclude-workflow-initiator-as-approver flag: strconv.ParseBool: parsing "": invalid syntax

my workflow step:

          - uses: trstringer/manual-approval@v1
             with:
                 secret: ${{ github.TOKEN }}
                 approvers: jieey1140
                 minimum-approvals: 1
                 issue-title: 'Deploying Production'

self-host-runner ENV:

OS: Ubuntu 22.04 Docker: Installed.

I need your help!

jieey1140 avatar Nov 21 '22 06:11 jieey1140

Thank you for opening this issue! Is this an open source repo? If so, could you share the link with me? I'm not able to reproduce this issue with your example:

      - name: Wait for approval
        uses: trstringer/manual-approval@v1
        with:
          secret: ${{ secrets.GITHUB_TOKEN }}
          approvers: trstringer
          minimum-approvals: 1
          issue-title: 'Deploying Production'

This works as intended. But if I add the empty option, then I can get this error:

      - name: Wait for approval
        uses: trstringer/manual-approval@v1
        with:
          secret: ${{ secrets.GITHUB_TOKEN }}
          approvers: trstringer
          minimum-approvals: 1
          issue-title: 'Deploying Production'
          exclude-workflow-initiator-as-approver:

error retrieving approvers: error parsing exclude-workflow-initiator-as-approver flag: strconv.ParseBool: parsing "": invalid syntax

Can you make sure that you're not specifying an empty exclude-workflow-initiator-as-approver parameter?

trstringer avatar Nov 21 '22 14:11 trstringer

@trstringer

The same error occurs when you add these parameters. Problem only occurs with self-host-runner! I have attached a picture. :)

(The mention repository above is a private repository.)

Thank you.

Screen Shot 2022-11-22 at 1 08 33 AM

jieey1140 avatar Nov 21 '22 16:11 jieey1140

Same for me, but different issue on a self-hosted runner (amd64). Private repo. Using GitHub runners works fine: Get "https://api.github.com/orgs/XXX/teams/gaspo53/members": dial tcp: i/o timeout Creating issue in repo XXX/XXX with the following content: Title: Manual approval required for workflow run 3565266281: Deploying INF-40-eks-cluster-should-have-git-hub-runners-deployed to xxx-xxx by gaspo53 Approvers: [gaspo53] Body: Workflow is pending manual review. URL: https://github.com/XXX/XXX/actions/runs/99999999999 Required approvers: [gaspo53] Respond "approved", "approve", "lgtm", "yes" to continue workflow or "denied", "deny", "no" to cancel. error creating issue: Post "https://api.github.com/repos/XXX/XXX/issues": dial tcp: i/o timeout

gaspo53 avatar Nov 29 '22 18:11 gaspo53

Hi @gaspo53

Your issue seems to be an issue caused due Docker's daemon socket connecting with the NAT GW of your virtual network.

This issue seems to be about 3 years old, so could you please confirm if you are still facing the issue @jieey1140 @gaspo53 . Apologies for so late replies.

snskArora avatar Jun 13 '25 22:06 snskArora

Hi! Not facing the issue anymore. Thanks!

gaspo53 avatar Jun 18 '25 13:06 gaspo53

Thank you!

snskArora avatar Jun 19 '25 06:06 snskArora