feat: overwrite input in middleware

[IlyaSemenov]

Describe the feature you'd like to request

The middlewares can currently extend/overwrite the context. They can technically modify the input with return next({ input: newInput }) in the same manner, but that's not reflected in types in the downstream procedures.

I would like the input type change to be reflected in types, the same way as it happens with the context.

Consider the example:

const orgProcedure = procedure
  .input(v.object({
    orgId: v.pipe(v.string(), v.uuid()),
    orgAccessKey: v.string(), // Imaginary data
  }))
  .use(async ({ input: { orgId, orgAccessKey, ...input }, next }) => {
    const org = await db.org.findOptional(orgId).select("id", "name")
      .where({ orgAccessKey }) // Imaginary access check
    assertHttp404NotFound(org, "Org not found")
    return next({
      ctx: { org }, // Add org object to context
      input, // Remove orgId and orgAccessKey from input
    })
  })

const editAccount = orgProcedure
  .input(v.object({
    accountId: v.pipe(v.string(), v.uuid()),
    name: v.string(),
    balance: v.number(),
  }))
  .mutation(async ({ ctx: { org }, input: { accountId, ...input } }) => {
    // Here input is { name, balance } in runtime,
    // but it's typed as { orgId, orgAccessKey, name, balance }.
    //
    // The query builder errors because of the extra fields in the type.
    await db.account.find(accountId).where({ orgId: org.id }).update(input)
  })

Currently, doing the above is not possible (it works in runtime, but it leads to type errors). As such, currently user can not really alter the input alongside the middleware chain; they must always deal with all input fields.

Describe the solution you'd like to see

In the example above, I would like the editAccount input to properly infer its new shape as coming from the upstream middleware.

Describe alternate solutions

Currently, all procedures must deal with the entire input object. That means two alternatives:

1. Extract parent input as unused vars

const editAccount = orgProcedure
  .input(v.object({
    accountId: v.pipe(v.string(), v.uuid()),
    name: v.string(),
    balance: v.number(),
  }))
  .mutation(async ({ ctx: { org }, input: { orgId, orgAccessKey, accountId, ...input } }) => {
    await db.account.find(accountId).where({ orgId: org.id }).update(input)
  })

Problems:

• Unused vars are not cool.
• If I add a new field to the upstream middleware, I will have to update ALL derived procedures that use the whole input.

2. Explicitly extract all needed fields

const editAccount = orgProcedure
  .input(v.object({
    accountId: v.pipe(v.string(), v.uuid()),
    name: v.string(),
    balance: v.number(),
  }))
  .mutation(async ({ ctx: { org }, input: { accountId, name, balance } }) => {
    await db.account.find(accountId).where({ orgId: org.id }).update({ name, balance })
  })

This is more reliable, but then each field must be repeated thrice:

1. in the validator
2. in input extractor
3. in update call

So for 20 fields, that gives 40 extra words.

Additional information

No response

👨‍👧‍👦 Contributing

• [x] 🙋‍♂️ Yes, I'd be down to file a PR implementing this feature!

[DJanocha]

could you share you package.json file or the content trpc-related? I'm currently struggling with overiding input in middleware. I'm not changing the shape of input, just values inside. To be more precise: I want to change only the dates from the input to change them by the proper timezone difference so that filtering by 'startDateTime' and 'endDateTime' works proper (eg from day X, hour: 00:00:00, not day X-1, hour: 22:00:00).

my big picture is:

1. I pass browser's timezone via header (eg : "timezone-diff-in-minutes"),
2. i created timezonedProcedure that maps over input and changes the value of each Date property by as many minutes as the value of timezone-diff-in-minutes tells us to.
3. In procedure (eg "animals.findByBIrthTime") the input passed to 'query' function is not a modified by me input, but the raw one.

it's the relevant part of my pnpm-workspace.yml file:

  "@trpc/client": ^11.3.1
  "@trpc/server": ^11.3.1
  "@trpc/next": ^11.3.1
  "@trpc/react-query": ^11.3.1