route-node icon indicating copy to clipboard operation
route-node copied to clipboard

fullName in callback is inconsistent?

Open c-dante opened this issue 6 years ago • 0 comments

Not sure what the intention is here: https://github.com/troch/route-node/blob/71fd8d9053c223ef9e7e699df2ab677852280332/modules/RouteNode.ts#L142-L161

But in the cb, the name field is overwritten by this fullName property.

This is the only time in the entire lifecycle of the RouteNode where the name is obscured and overwritten as such.

Is this intentional? It's breaking code in router5 (and probably other places?) that rely on the callback.

It seems extra bad that the node itself doesn't get this fullName property -- just the spread in this callback.

c-dante avatar Dec 18 '19 21:12 c-dante