Save and load user_data for p4est

[benegee]

This fixes restating when using AMR. Resolves #1914

[github-actions[bot]]

Review checklist

This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.

Purpose and scope

• [ ] The PR has a single goal that is clear from the PR title and/or description.
• [ ] All code changes represent a single set of modifications that logically belong together.
• [ ] No more than 500 lines of code are changed or there is no obvious way to split the PR into multiple PRs.

Code quality

• [ ] The code can be understood easily.
• [ ] Newly introduced names for variables etc. are self-descriptive and consistent with existing naming conventions.
• [ ] There are no redundancies that can be removed by simple modularization/refactoring.
• [ ] There are no leftover debug statements or commented code sections.
• [ ] The code adheres to our conventions and style guide, and to the Julia guidelines.

Documentation

• [ ] New functions and types are documented with a docstring or top-level comment.
• [ ] Relevant publications are referenced in docstrings (see example for formatting).
• [ ] Inline comments are used to document longer or unusual code sections.
• [ ] Comments describe intent ("why?") and not just functionality ("what?").
• [ ] If the PR introduces a significant change or new feature, it is documented in NEWS.md.

Testing

• [ ] The PR passes all tests.
• [ ] New or modified lines of code are covered by tests.
• [ ] New or modified tests run in less then 10 seconds.

Performance

• [ ] There are no type instabilities or memory allocations in performance-critical parts.
• [ ] If the PR intent is to improve performance, before/after time measurements are posted in the PR.

Verification

• [ ] The correctness of the code was verified using appropriate tests.
• [ ] If new equations/methods are added, a convergence test has been run and the results are posted in the PR.

Created with :heart: by the Trixi.jl community.

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.13%. Comparing base (8665300) to head (7b11b29).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1915      +/-   ##
==========================================
+ Coverage   95.93%   96.13%   +0.19%     
==========================================
  Files         460      460              
  Lines       36952    36956       +4     
==========================================
+ Hits        35449    35524      +75     
+ Misses       1503     1432      -71     

Flag	Coverage Δ
unittests	96.13% <100.00%> (+0.19%)	:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[ranocha]

Can we have a CI test for this?

[benegee]

I am still unhappy with this fix. While new_p4est allows to just allocate user data, load_p4est requires to also provide the data. So in the end I am only saving the data to have memory allocated upon restart.

I also do not know if there was a good reason for not saving user data in the first place.

[benegee]

The solution is to use p4est_reset_data! https://github.com/cburstedde/p4est/issues/308

[DanielDoehring]

So with this, is it possible to restart a simulation and refine the initial condition?

[benegee]

So with this, is it possible to restart a simulation and refine the initial condition?

Just checked with this example here and it seems to work.

[DanielDoehring]

Just checked with this example here and it seems to work.

Cool, thanks for picking this up!

[ranocha]

So with this, is it possible to restart a simulation and refine the initial condition?

Just checked with this example here and it seems to work.

Do we have a test for this? Or is it covered by the tests we already have?

[DanielDoehring]

Do we have a test for this? Or is it covered by the tests we already have?

So the newly introduced test does exactly this. So in some sense we "test for crash".

[benegee]

Thanks for your feedback!

Following @JoshuaLampert 's comment above and https://github.com/trixi-framework/Trixi.jl/pull/1384#issuecomment-1505878188 I removed ode_default_options() in elixir_advection_{extended,restart,restart_amr}.jl for p4est_2d_dgsem and tree_2d_dgsem.

In the new elixir_advection_restart_amr.jl for p4est_2d_dgsem and tree_2d_dgsem I set adapt_initial_condition = true. This still tests the restarting capability in general.

[ranocha]

Thanks! However, some test tolerances are not satisfied right now: https://github.com/trixi-framework/Trixi.jl/actions/runs/9398803634/job/25884924262?pr=1915#step:7:2874

[benegee]

Thanks! However, some test tolerances are not satisfied right now: https://github.com/trixi-framework/Trixi.jl/actions/runs/9398803634/job/25884924262?pr=1915#step:7:2874

Yes! I wanted to update them, but it seems I also introduced some issue in the MPI test. I'm on it.

[benegee]

It seems to work now!