change the configuration of engineArgs in config.pbtxt
CLA has been accepted by the Triton Team. This PR can be merged at our discretion.
CLA has been accepted by the Triton Team. This PR can be merged at our discretion.
@nv-kmcgill53 OK, thank u so much.
Hi @activezhao, thanks for your work! I was thinking about the structure of this tutorial. I would like to keep original version of this tutorial, which utilizes vllm_backend repo under QuickDeploy section. How about we move this tutorial under a new folder Customization with a new README and suggested model.py and config.pbtxt. Then, in the README you can describe what new methods you've added to model.py and config.pbtxt. What do you think about this idea?
Hi @activezhao, thanks for your work! I was thinking about the structure of this tutorial. I would like to keep original version of this tutorial, which utilizes
vllm_backendrepo underQuickDeploysection. How about we move this tutorial under a new folderCustomizationwith a new README and suggestedmodel.pyandconfig.pbtxt. Then, in the README you can describe what new methods you've added tomodel.pyandconfig.pbtxt. What do you think about this idea?
Hi @oandreeva-nv Cool, that sounds pretty good, it's a good idea.
And could you please help us build the basic code structure, and then we can fill things in?
Hi @oandreeva-nv I have created a folder named Customization with new README and suggested model.py and config.pbtxt.
Could you please review the code?
Thanks
Hi @activezhao , pre-commit hook failed unfortunately, could you please fix the formatting?
Hi @activezhao , pre-commit hook failed unfortunately, could you please fix the formatting?
OK, I will fix them.
Hi @oandreeva-nv I have just updated README and adjusted directory structure, could you please help me to review the code? Thanks