tutorials icon indicating copy to clipboard operation
tutorials copied to clipboard

change the configuration of engineArgs in config.pbtxt

Open activezhao opened this issue 2 years ago • 8 comments

activezhao avatar Nov 22 '23 09:11 activezhao

CLA has been accepted by the Triton Team. This PR can be merged at our discretion.

nv-kmcgill53 avatar Nov 22 '23 18:11 nv-kmcgill53

CLA has been accepted by the Triton Team. This PR can be merged at our discretion.

@nv-kmcgill53 OK, thank u so much.

activezhao avatar Nov 23 '23 01:11 activezhao

Hi @activezhao, thanks for your work! I was thinking about the structure of this tutorial. I would like to keep original version of this tutorial, which utilizes vllm_backend repo under QuickDeploy section. How about we move this tutorial under a new folder Customization with a new README and suggested model.py and config.pbtxt. Then, in the README you can describe what new methods you've added to model.py and config.pbtxt. What do you think about this idea?

oandreeva-nv avatar Nov 27 '23 19:11 oandreeva-nv

Hi @activezhao, thanks for your work! I was thinking about the structure of this tutorial. I would like to keep original version of this tutorial, which utilizes vllm_backend repo under QuickDeploy section. How about we move this tutorial under a new folder Customization with a new README and suggested model.py and config.pbtxt. Then, in the README you can describe what new methods you've added to model.py and config.pbtxt. What do you think about this idea?

Hi @oandreeva-nv Cool, that sounds pretty good, it's a good idea.

And could you please help us build the basic code structure, and then we can fill things in?

activezhao avatar Nov 28 '23 01:11 activezhao

Hi @oandreeva-nv I have created a folder named Customization with new README and suggested model.py and config.pbtxt.

Could you please review the code?

Thanks

activezhao avatar Dec 04 '23 08:12 activezhao

Hi @activezhao , pre-commit hook failed unfortunately, could you please fix the formatting?

oandreeva-nv avatar Dec 27 '23 19:12 oandreeva-nv

Hi @activezhao , pre-commit hook failed unfortunately, could you please fix the formatting?

OK, I will fix them.

activezhao avatar Dec 29 '23 15:12 activezhao

Hi @oandreeva-nv I have just updated README and adjusted directory structure, could you please help me to review the code? Thanks

activezhao avatar Jan 04 '24 18:01 activezhao