trino-python-client icon indicating copy to clipboard operation
trino-python-client copied to clipboard
verified publisher icon trinodb

Add support for TIMEZONE

Open ulisesojeda opened this issue 3 years ago • 1 comments

Add support for TIMEZONE

Fixes https://github.com/trinodb/trino-python-client/issues/27

ulisesojeda avatar Oct 07 '22 06:10 ulisesojeda

Thanks for this contribution, overall looks very good.

Note that this also should be documented.

Done the doc. Thanks for your review and comments @mdesmet !

ulisesojeda avatar Oct 12 '22 10:10 ulisesojeda

@ulisesojeda : Please don't merge master into your branch but rebase on master.

mdesmet avatar Oct 27 '22 10:10 mdesmet

@ebyhr @hashhar could you please check it?

ulisesojeda avatar Oct 31 '22 15:10 ulisesojeda

LGTM % some comments.

Thanks for this.

I plan to not merge this for 0.320.0 so that other features can be part of 0.320.0 which people might be waiting for. Then 0.321.0 can introduce this change. I hope that's ok?

While there's a way to preserve old beahviour it requires someone to read release notes so I'd like to announce on Trino community before this change.

Sure. Thanks for the review @hashhar

ulisesojeda avatar Nov 18 '22 19:11 ulisesojeda

Rebased. Will merge once CI is done.

hashhar avatar Dec 12 '22 09:12 hashhar