trino-python-client icon indicating copy to clipboard operation
trino-python-client copied to clipboard
verified publisher icon trinodb

Added black (code formatting) and isort (sorting imports)

Open mdesmet opened this issue 3 years ago • 2 comments

Introduces black (code formatting) and isort (sorting imports)

  • Added black and isort as "test" dependencies (maybe we should rename this to "dev" dependencies
  • Run pre-commit run --all-files to standardize formatting and import sorting.

mdesmet avatar Aug 19 '22 12:08 mdesmet

Some flakyness in the tests, might be related to not having merged #220 but not totally sure.

mdesmet avatar Sep 01 '22 11:09 mdesmet

@mdesmet See also https://github.com/trinodb/trino-python-client/commit/cffd2b232d9298321c34430f0ac829f6b6ebea8f#r83714277 - not sure if that's the cause.

hashhar avatar Sep 12 '22 09:09 hashhar

@hashhar: As discussed I have removed black from this PR and only kept isort. PTAL

mdesmet avatar Oct 27 '22 12:10 mdesmet

@hashhar: PTAL

mdesmet avatar Oct 31 '22 08:10 mdesmet