trinker
Make rm_xxx fully dependent on stringi
I can see from the source code that ex_xxx are dependent on stringi while rm_xxx is still dependent on base gsub. Can we not change these to stringi? Let me know if I can assist anyway.
At the time this was written my tests indicated base gsub was faster but that means the regexes won't be 100% compatible
On Thu, Oct 11, 2018, 8:55 AM Indranil Gayen [email protected] wrote:
I can see from the source code that ex_xxx are dependent on stringi while rm_xxx is still dependent on base gsub. Can we not change these to stringi? Let me know if I can assist anyway.
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/trinker/qdapRegex/issues/28, or mute the thread https://github.com/notifications/unsubscribe-auth/ABrnzgaXDm7wOC94eUL_62-mdMTTkDD2ks5ujz-rgaJpZM4XXezL .
Can we not opt for an option which let the user choose between gsub or stringi ?
BTW, I think stringi is faster now, check following references :
https://stackoverflow.com/questions/29646744/different-output-using-stringi-and-gsub-using-the-same-pattern-on-the-same-stri
https://rstudio-pubs-static.s3.amazonaws.com/45999_4b4a72d1450b4ca9a94385bda47d96fe.html