node-filesystem-cache icon indicating copy to clipboard operation
node-filesystem-cache copied to clipboard

The put method is treating the timespan as ms.

Open daniebker opened this issue 5 years ago • 0 comments

I've been trying to cache something for 65 days but noticed that the cache has been expiring and the file removed. Date.now() returns milliseconds elapsed since Jan 1st 1970 00:00: 00 UTC. So the value passed to put is actually treated as MS, not seconds. https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Date/now

Repro

  1. Put an Item in the cache with seconds param set to: 5616000
  2. Expected that the unix timestamp in the TTL is 1603391361815 (Oct 22, 65 days from Aug 18)
  3. Actual timestamp in the cache is 2 hours later.

I can fix it locally by multiplying my value by 1000 which gives me the unix timestamp I expect.

daniebker avatar Aug 18 '20 18:08 daniebker