modus-web-components icon indicating copy to clipboard operation
modus-web-components copied to clipboard

Content tree: Keyboard navigation to move items

Open ElishaSamPeterPrabhu opened this issue 1 year ago • 3 comments

Description

  • Added Keyboard navigation to move items from one position to another

References Fixes #1597

Type of change

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] Documentation update

How Has This Been Tested?

Checklist

  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings
  • [x] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes
  • [ ] Any dependent changes have been merged and published in downstream modules
  • [x] I have checked my code and corrected any misspellings

ElishaSamPeterPrabhu avatar May 14 '24 05:05 ElishaSamPeterPrabhu

Deploy Preview for moduswebcomponents ready!

Name Link
Latest commit 41bfabe924c65e87b9b48c9f2c77dc4f1b112256
Latest deploy log https://app.netlify.com/sites/moduswebcomponents/deploys/666145e40a7e9e0008dc3761
Deploy Preview https://deploy-preview-2523--moduswebcomponents.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

Lighthouse
1 paths audited
Performance: 24 (no change from production)
Accessibility: 98 (no change from production)
Best Practices: 92 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar May 14 '24 05:05 netlify[bot]

@ElishaSamPeterPrabhu 2 things: When i pick an item and press down once, it does not move to where i expect it to go, it essentially is putting the line where the item already is, requiring that i press down twice. Can we have it so the down arrow is aware enough to put it where we expect?

Can we handle escape key to cancel as well?

cjwinsor avatar May 16 '24 13:05 cjwinsor

@ElishaSamPeterPrabhu 2 things: When i pick an item and press down once, it does not move to where i expect it to go, it essentially is putting the line where the item already is, requiring that i press down twice. Can we have it so the down arrow is aware enough to put it where we expect?

Can we handle escape key to cancel as well?

Updated the up and down behavior as expected and added escape to cancel draggable state

ElishaSamPeterPrabhu avatar May 20 '24 06:05 ElishaSamPeterPrabhu