trigger.dev icon indicating copy to clipboard operation
trigger.dev copied to clipboard

feat: support async `io.runTask` error callback

Open minyoung opened this issue 1 year ago • 1 comments

Closes #909

✅ Checklist

  • [x] I have followed every step in the contributing guide
  • [x] The PR title follows the convention.
  • [x] I ran and tested the code works

Testing

Ran with a patched @trigger.dev/sdk (using pnpm.patchedDependencies), verified that there were no type errors and that returning { skipRetrying: true } worked correctly with and without an async error callback (at different task.attempt values)


Changelog

Support async io.runTask error callback

💯

minyoung avatar Feb 23 '24 20:02 minyoung

🦋 Changeset detected

Latest commit: b03871900bdc9aa4c65c1bbde61c989cf835be98

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Feb 23 '24 20:02 changeset-bot[bot]

Sorry this PR coincided with major platform so didn't get the attention it deserved at the time. Version 2 is deprecated and with be end-of-life on Jan 31.

matt-aitken avatar Sep 18 '24 11:09 matt-aitken