trigger.dev icon indicating copy to clipboard operation
trigger.dev copied to clipboard

[TRI-1791] client.getRuns() doesn't return runs if you pass cursor: undefined.

Open matt-aitken opened this issue 2 years ago • 1 comments

The issue is with this code: https://github.com/triggerdotdev/trigger.dev/blob/5359af12426fad3576af2aa4a3abb5f4b0c25fa1/packages/core/src/searchParams.ts#L11

It doesn't check in the loop for undefined, and string(undefined) evaluates to "undefined" which obviously isn't a valid cursor.

It should do an undefined check in the loop and continue.

TRI-1791

matt-aitken avatar Dec 20 '23 09:12 matt-aitken

This is fixed by this commit: https://github.com/triggerdotdev/trigger.dev/commit/03703af682ab452a57a0c0e21e7b829eda564d4e

It needs to be deployed to cloud, which will happen in January.

matt-aitken avatar Dec 20 '23 11:12 matt-aitken