trigger.dev icon indicating copy to clipboard operation
trigger.dev copied to clipboard

added SMTP support and removed resend dependency

Open Chigala opened this issue 2 years ago • 7 comments

Description

Added SMTP support

Changes

  • Removed resend
  • Added nodemailer
  • added support for SMTP

fixes #282

Chigala avatar Aug 11 '23 14:08 Chigala

⚠️ No Changeset found

Latest commit: 55c5df63ec210b8426fb74561aba780e96d89c0c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Aug 11 '23 14:08 changeset-bot[bot]

You may notice some issues with SMTP depending on provider. Might be worth enabling pooling if that happens (yes, that's my code word now).

nicktrn avatar Aug 16 '23 15:08 nicktrn

Lol, I'll definitely look into this. Thanks

Chigala avatar Aug 16 '23 15:08 Chigala

@Chigala to merge this that checklist above from @ericallam needs to be completed

matt-aitken avatar Aug 18 '23 09:08 matt-aitken

@matt-aitken I've already sent pull requests to the docker and fiy.io repositories.

Chigala avatar Aug 18 '23 09:08 Chigala

@Chigala when you get a chance could you check my comment above?

ericallam avatar Aug 23 '23 09:08 ericallam

is this planned? I can recreate the PR and update the code if @Chigala is not available

gautamsi avatar Aug 10 '24 07:08 gautamsi

also happy to help work on a revival of this :pray:

ghostdevv avatar Dec 19 '24 15:12 ghostdevv

Thanks for this PR @Chigala, sorry it's taken so long. There's a new PR inspired by this #1580.

matt-aitken avatar Dec 29 '24 17:12 matt-aitken