trigger.dev icon indicating copy to clipboard operation
trigger.dev copied to clipboard

chore(webapp): improvements to app emails

Open samejr opened this issue 4 months ago • 2 comments

Updates these emails sent from the app:

  • Welcome email
  • Invite email
  • Magic link login email

With these improvements:

  • Updates them all to use Tailwind
  • Updates react-email to the latest
  • Improved styling and layout
  • Fixes some very outdated links that were 404s

New layouts (without images and dynamic content loaded):

Welcome email CleanShot 2025-09-07 at 15 11 46@2x

Login email CleanShot 2025-09-07 at 15 11 31@2x

Invite email CleanShot 2025-09-07 at 15 11 16@2x

samejr avatar Sep 07 '25 14:09 samejr

⚠️ No Changeset found

Latest commit: 5448310e51bb1cbabb94515477fa4f4a7ceab906

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Sep 07 '25 14:09 changeset-bot[bot]

Walkthrough

This PR applies broad cross-cutting changes: multiple email templates migrated to Tailwind-based @react-email components and package updates; email transports (SMTP/AWS SES) now await rendered HTML; invite schema and several email props updated. It adds a Redis-backed magic-link rate limiter and integrates rate-limiting into the login magic flow. The run-engine gains repair/reporting features, new RunQueue concurrency/clear APIs, worker repairSnapshot, and many internals updated (span/event APIs, span presenters, event repository). Webapp routes and presenters were tightened to enforce membership checks; env schema gained LOGIN_RATE_LIMITS_ENABLED; personal access token revoke now requires userId. Helm/docker images and chart/values updated for legacy Bitnami images and new webapp init/tokenSyncer images. Miscellaneous type and import refinements across the codebase.

Estimated code review effort

🎯 5 (Critical) | ⏱️ ~120 minutes

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The description outlines which emails were updated and the nature of the improvements, but it does not follow the repository’s required template sections: it lacks the “Closes #” reference, the ✅ Checklist, a Testing section, a Changelog entry, and the formal Screenshots heading. Please update the description to match the template by adding “Closes #,” completing the ✅ Checklist, adding a “Testing” section with your test steps, a “Changelog” summary, and placing the screenshots under the “## Screenshots” heading.
Docstring Coverage ⚠️ Warning Docstring coverage is 3.23% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (1 passed)
Check name Status Explanation
Title Check ✅ Passed The title “chore(webapp): improvements to app emails” clearly reflects that the primary change is improving the application’s email templates, follows the project’s conventional commit style, and is concise enough for teammates to understand the core update at a glance.
✨ Finishing touches
  • [ ] 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • [ ] Create PR with unit tests
  • [ ] Post copyable unit tests in a comment
  • [ ] Commit unit tests in branch nicer-app-emails

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot] avatar Sep 07 '25 14:09 coderabbitai[bot]