Dashboard: Org menu improvements for admins
Only show the "Switch organization" menu when you have multiple orgs, otherwise show a "New organization" button
Adds a button to get back to the admin dashboard if you're an admin
No buttons visible if you're not an admin
Moves impersonation link from the menu dropdown to the main side menu
Summary by CodeRabbit
-
New Features
- Added an admin dashboard link to the side menu for users with admin access, accessible via a tooltip and cog icon.
-
Improvements
- Updated impersonation banner to display a tooltip on hover instead of visible text, with enhanced styling and placement in the header area.
- Refined organization switcher to improve menu labeling and display based on the number of organizations.
- Adjusted visual cues for impersonation status in the side menu header.
⚠️ No Changeset found
Latest commit: ec64b4c352016b852119267c0905579efd8dd2a2
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
Walkthrough
This update modifies the user interface for admin and impersonation features in the web application. The ImpersonationBanner button is now wrapped in a tooltip, with the button's text hidden and shown only on hover. The side menu gains a conditional admin dashboard link, visible to users with admin access, and moves the impersonation banner to the header. Organization switching is refined for clarity, and a new utility function for the admin path is introduced. No exported function signatures are changed, except for the addition of the new adminPath function.
Changes
| File(s) | Change Summary |
|---|---|
apps/webapp/app/components/ImpersonationBanner.tsx |
The impersonation stop button is now wrapped in a tooltip, hiding its text and displaying it on hover. The button's styling is updated, and unnecessary wrappers are removed. |
apps/webapp/app/components/navigation/SideMenu.tsx |
Adds an admin dashboard link visible to admins, moves the impersonation banner to the header, updates visual cues for impersonation, and refines organization switching and menu item labeling. Removes some conditional border stylings and adjusts menu structure. |
apps/webapp/app/utils/pathBuilder.ts |
Adds a new exported function adminPath that returns the admin dashboard path string (/@). No changes to existing functions. |
Sequence Diagram(s)
sequenceDiagram
participant User
participant SideMenu
participant useHasAdminAccess
participant ImpersonationBanner
participant Tooltip
participant pathBuilder
User->>SideMenu: Render side menu
SideMenu->>useHasAdminAccess: Check admin access
useHasAdminAccess-->>SideMenu: Return access status
alt User is admin
SideMenu->>pathBuilder: Get admin path
SideMenu->>Tooltip: Wrap admin dashboard link in tooltip
end
SideMenu->>ImpersonationBanner: Render impersonation banner (with tooltip)
Possibly related PRs
-
triggerdotdev/trigger.dev#1801: Also modifies the
ImpersonationBannercomponent, focusing on button styling and structure, indicating closely related changes to the same UI element.
Suggested reviewers
- matt-aitken
Poem
A button now hides its amber glow,
Revealed by a tooltip’s gentle show.
The admin cog spins for those with the key,
While banners and borders dance with glee.
New paths are forged, selectors refined—
In this webby warren, improvements aligned!
🐇✨
📜 Recent review details
Configuration used: CodeRabbit UI Review profile: CHILL Plan: Pro
📥 Commits
Reviewing files that changed from the base of the PR and between 5e2a96e3cb3a9553724600d38b0ba0ecec316462 and ec64b4c352016b852119267c0905579efd8dd2a2.
📒 Files selected for processing (2)
-
apps/webapp/app/components/ImpersonationBanner.tsx(1 hunks) -
apps/webapp/app/components/navigation/SideMenu.tsx(7 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
- apps/webapp/app/components/ImpersonationBanner.tsx
- apps/webapp/app/components/navigation/SideMenu.tsx
⏰ Context from checks skipped due to timeout of 90000ms (7)
- GitHub Check: e2e / 🧪 CLI v3 tests (windows-latest - pnpm)
- GitHub Check: e2e / 🧪 CLI v3 tests (windows-latest - npm)
- GitHub Check: e2e / 🧪 CLI v3 tests (ubuntu-latest - pnpm)
- GitHub Check: typecheck / typecheck
- GitHub Check: e2e / 🧪 CLI v3 tests (ubuntu-latest - npm)
- GitHub Check: units / 🧪 Unit Tests
- GitHub Check: Analyze (javascript-typescript)
✨ Finishing Touches
- [ ] 📝 Generate Docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
🪧 Tips
Chat
There are 3 ways to chat with CodeRabbit:
- Review comments: Directly reply to a review comment made by CodeRabbit. Example:
-
I pushed a fix in commit <commit_id>, please review it. -
Generate unit testing code for this file. -
Open a follow-up GitHub issue for this discussion.
-
- Files and specific lines of code (under the "Files changed" tab): Tag
@coderabbitaiin a new review comment at the desired location with your query. Examples:-
@coderabbitai generate unit testing code for this file. -
@coderabbitai modularize this function.
-
- PR comments: Tag
@coderabbitaiin a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:-
@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase. -
@coderabbitai read src/utils.ts and generate unit testing code. -
@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format. -
@coderabbitai help me debug CodeRabbit configuration file.
-
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.
CodeRabbit Commands (Invoked using PR comments)
-
@coderabbitai pauseto pause the reviews on a PR. -
@coderabbitai resumeto resume the paused reviews. -
@coderabbitai reviewto trigger an incremental review. This is useful when automatic reviews are disabled for the repository. -
@coderabbitai full reviewto do a full review from scratch and review all the files again. -
@coderabbitai summaryto regenerate the summary of the PR. -
@coderabbitai generate docstringsto generate docstrings for this PR. -
@coderabbitai generate sequence diagramto generate a sequence diagram of the changes in this PR. -
@coderabbitai resolveresolve all the CodeRabbit review comments. -
@coderabbitai configurationto show the current CodeRabbit configuration for the repository. -
@coderabbitai helpto get help.
Other keywords and placeholders
- Add
@coderabbitai ignoreanywhere in the PR description to prevent this PR from being reviewed. - Add
@coderabbitai summaryto generate the high-level summary at a specific location in the PR description. - Add
@coderabbitaianywhere in the PR title to generate the title automatically.
CodeRabbit Configuration File (.coderabbit.yaml)
- You can programmatically configure CodeRabbit by adding a
.coderabbit.yamlfile to the root of your repository. - Please see the configuration documentation for more information.
- If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation:
# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
Documentation and Community
- Visit our Documentation for detailed information on how to use CodeRabbit.
- Join our Discord Community to get help, request features, and share feedback.
- Follow us on X/Twitter for updates and announcements.
A small update to simplify showing admin and impersonation UI.
When admin, show a grey "users" button to go back to the admin dashboard:
When impersonating, show a yellow "user-minus" button to stop impersonating: