trigger.dev icon indicating copy to clipboard operation
trigger.dev copied to clipboard
Published 2 weeks ago • verified publisher icon triggerdotdev

Remove Bun version warning

Open 0x77dev opened this issue 10 months ago • 5 comments

✅ Checklist

  • [x] I have followed every step in the contributing guide
  • [x] The PR title follows the convention.
  • [x] I ran and tested the code works

Changelog

Summary by CodeRabbit

  • Documentation
    • Removed outdated warnings about specific Bun version requirements.
    • Updated guidance to streamline the setup process for Trigger.dev in Bun projects.
    • Introduced experimental support for Bun, simplifying the setup instructions.

0x77dev avatar Feb 26 '25 19:02 0x77dev

⚠️ No Changeset found

Latest commit: 59c98e26d89571ee5436c124d36b894d2e5db350

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Feb 26 '25 19:02 changeset-bot[bot]

Walkthrough

A warning about a specific Bun version requirement for the dev command has been removed from the Bun documentation. The update eliminates the guidance to use Bun version 1.1.24 or lower due to an IPC bug. Instead, the docs now highlight experimental support for Bun and outline the setup process for Trigger.dev in Bun projects. No changes were made to exported or public entities.

Changes

File(s) Change Summary
docs/guides/.../bun.mdx Removed the warning regarding Bun version constraints and associated installation command. Updated the guide to reflect experimental support and setup instructions for Bun projects.

Possibly related PRs

  • triggerdotdev/trigger.dev#1409: Introduces a similar warning about Bun version requirements, directly linking to how Bun versioning is handled.

Poem

I'm a rabbit on the run, with code so sleek and neat,
Hopping past old warnings, making our docs complete.
Bun's experimental magic now shines in every line,
Trigger.dev setup is fresh and oh so fine!
Let’s celebrate in hops and bytes, with joy that’s hard to beat.

📜 Recent review details

Configuration used: CodeRabbit UI Review profile: CHILL Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 376a0c5d04254e601d3add1d7eae5a18ba7a0910 and 59c98e26d89571ee5436c124d36b894d2e5db350.

📒 Files selected for processing (1)
  • docs/guides/frameworks/bun.mdx (0 hunks)
💤 Files with no reviewable changes (1)
  • docs/guides/frameworks/bun.mdx

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Feb 26 '25 19:02 coderabbitai[bot]

@0x77dev is bun working for you?

ericallam avatar Feb 26 '25 20:02 ericallam

At this place https://github.com/triggerdotdev/trigger.dev/pull/1409/files it should also use the newest Bun version. It is right now difficult to work with Bun in Trigger.Dev because it is not using a new version of Bun.

HansKristoffer avatar Mar 23 '25 18:03 HansKristoffer

We should definitely use a more recent version and maybe make this configurable.

The reason this isn't quite as simple is that when we tested newer releases recently, there were still issues once deployed on our infra. Will have to give this another spin when we get a chance.

This PR is definitely not enough though - we'll have to make changes in at least the places @HansKristoffer linked, and possibly add a new runtime option.

nicktrn avatar Apr 23 '25 11:04 nicktrn

We decided to remove our experimental Bun support entirely. Node will be the only supported runtime on v4+.

  • https://github.com/triggerdotdev/trigger.dev/pull/2048

It was never well tested and there wasn't much demand in the community. Version updates became a problem due to bugs and incompatibilities, e.g. OTel and checkpoints. There were additional challenges with the node+bun image we had to use given our entry point only supports node and has to spawn bun processes.

nicktrn avatar May 14 '25 11:05 nicktrn