trigger.dev icon indicating copy to clipboard operation
trigger.dev copied to clipboard

New Help & Feedback menu and tab-selected styles

Open samejr opened this issue 1 year ago • 3 comments

Created a new menu for the Help & Feedback CleanShot 2024-10-02 at 09 56 44@2x

Help & Feedback button appears just above the Free Plan usage meter CleanShot 2024-10-02 at 10 07 57@2x

Moved the contact us form into a modal CleanShot 2024-10-02 at 10 08 40@2x

All tab-selectable items now have a unified style for their focus-visible state. I had to improve this as part of this PR as the short cut keys selected items that weren't getting highlighted. CleanShot 2024-10-02 at 10 08 56@2x

Summary by CodeRabbit

Release Notes

  • New Features

    • Introduced a dialog-based interface for the Feedback component, enhancing user interaction.
    • Added a new Help and Feedback section in the SideMenu for improved user assistance.
    • Implemented keyboard shortcut capabilities in the Popover component.
    • Enhanced the Select component with improved styling and usability.
  • Bug Fixes

    • Improved rendering and accessibility for various components, including the RadioButton and Switch.
  • Style

    • Updated focus styles across multiple components to enhance accessibility and visual feedback.
    • Refined layout and padding in several components for better user experience.
  • Documentation

    • Added new guides and components to documentation for better user reference.

samejr avatar Oct 02 '24 17:10 samejr

⚠️ No Changeset found

Latest commit: dfce7d5156daa54d67ea44c6f1d8fe07c5828dd9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Oct 02 '24 17:10 changeset-bot[bot]

[!CAUTION]

Review failed

The head commit changed during the review from d4ee186b4be996f6a598baa5bf51ff04a8964395 to dfce7d5156daa54d67ea44c6f1d8fe07c5828dd9.

Walkthrough

The pull request introduces significant modifications across multiple components in the web application. Key changes include the transition from a Sheet layout to a Dialog in the Feedback component, enhanced styling and functionality in various UI elements, and the introduction of new components like HelpAndFeedback and PopoverSideMenuTrigger. Additionally, updates to the Tailwind CSS configuration enhance accessibility and design consistency. Overall, the changes aim to improve user interaction, visual feedback, and the overall user experience.

Changes

File Path Change Summary
apps/webapp/app/components/Feedback.tsx Replaced Sheet layout with Dialog; added new state variable type; updated rendering logic for InfoPanel; removed LinkBanner.
apps/webapp/app/components/code/CodeBlock.tsx Added focus-custom class to TooltipTrigger.
apps/webapp/app/components/navigation/AccountSideMenu.tsx Renamed iconColor prop to activeIconColor for menu items.
apps/webapp/app/components/navigation/SideMenu.tsx Added new HelpAndFeedback component; updated SideMenuProps type; replaced iconColor with activeIconColor.
apps/webapp/app/components/navigation/SideMenuItem.tsx Introduced new props for icon color management; removed hasWarning prop; exported MenuCount function.
apps/webapp/app/components/primitives/AppliedFilter.tsx Added focus-custom class to button based on removable prop.
apps/webapp/app/components/primitives/Buttons.tsx Updated styling for button variants and added focus-custom class to button components.
apps/webapp/app/components/primitives/Dialog.tsx Modified DialogPrimitive.Close button styles.
apps/webapp/app/components/primitives/InfoPanel.tsx Changed header from Header3 to Header2.
apps/webapp/app/components/primitives/Input.tsx Updated containerBase string for input focus styling.
apps/webapp/app/components/primitives/PageHeader.tsx Enhanced focus styling for back button in PageTitle.
apps/webapp/app/components/primitives/Popover.tsx Added PopoverSideMenuTrigger component; updated existing triggers with focus-custom class.
apps/webapp/app/components/primitives/RadioButton.tsx Updated class names for styling changes in radio button components.
apps/webapp/app/components/primitives/Resizable.tsx Updated class names for PanelResizer.
apps/webapp/app/components/primitives/SegmentedControl.tsx Changed class name for RadioGroup.Option.
apps/webapp/app/components/primitives/Select.tsx Adjusted button styles and updated focus handling.
apps/webapp/app/components/primitives/Switch.tsx Updated styling for switch variations and focus states.
apps/webapp/app/components/primitives/Table.tsx Modified TableCell styles and added focus-custom class.
apps/webapp/app/components/primitives/Tabs.tsx Enhanced focus styles for TabLink and TabButton.
apps/webapp/app/components/primitives/TextArea.tsx Updated class names for textarea styling.
apps/webapp/app/components/primitives/Tooltip.tsx Modified TooltipContent and SimpleTooltip for accessibility improvements.
apps/webapp/app/components/runs/v3/RunFilters.tsx Updated rendering of Ariakit.Select to include focus-custom class.
apps/webapp/app/components/runs/v3/RunInspector.tsx Adjusted layout and padding for run information display.
apps/webapp/app/components/runs/v3/SpanInspector.tsx Enhanced spacing and simplified tab logic.
apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.v3.$projectParam.runs.$runParam/route.tsx UI adjustments and streamlined event handling for run logs.
apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.v3.$projectParam.runs.electric.$runParam/route.tsx UI adjustments and improved state management for run logs.
apps/webapp/app/routes/resources.feedback.ts Updated feedback type handling and validation schema.
apps/webapp/app/routes/resources.orgs.$organizationSlug.projects.v3.$projectParam.runs.$runParam.spans.$spanParam/route.tsx Adjusted layout and added new tab options for navigation.
apps/webapp/tailwind.config.js Added new color definitions and focus styles; introduced .focus-custom utility.
docs/guides/frameworks/introduction.mdx Added CardSequin component to CardGroup.
docs/mint.json Added new framework entry for "sequin" in documentation.
docs/snippets/card-sequin.mdx Introduced new Card component with SVG icon.

Possibly related PRs

  • #1314: This PR enhances documentation by introducing overview pages and improving examples, which may relate to the user interface changes in the Feedback component that also aim to improve user interaction.
  • #1368: The addition of the Sequin guide may connect with the changes in the Feedback component, as both involve enhancing user experience and functionality within the application.
  • #1371: Updates to the Sequin guide could be relevant as they focus on improving documentation and user guidance, similar to the enhancements made in the Feedback component.
  • #1396: The introduction of webhook guides may relate to the overall user experience improvements in the application, aligning with the objectives of enhancing user interaction in the Feedback component.

🐰 In the garden of code, we hop and play,
With dialogs and buttons, brightening the day.
From sheets to dialogs, a leap we take,
Enhancing the feedback, for all our sake.
So let’s celebrate, with a joyful cheer,
For every new feature, brings us near! 🎉


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Oct 02 '24 17:10 coderabbitai[bot]

pnpm add https://pkg.pr.new/triggerdotdev/trigger.dev/@trigger.dev/core@1374
pnpm add https://pkg.pr.new/triggerdotdev/trigger.dev/@trigger.dev/build@1374
pnpm add https://pkg.pr.new/triggerdotdev/trigger.dev/@trigger.dev/sdk@1374
pnpm add https://pkg.pr.new/triggerdotdev/trigger.dev@1374

commit: dfce7d5

pkg-pr-new[bot] avatar Oct 02 '24 17:10 pkg-pr-new[bot]