trigger.dev icon indicating copy to clipboard operation
trigger.dev copied to clipboard

Deploy refactor resolve step

Open codenem opened this issue 1 year ago • 1 comments

Closes #

✅ Checklist

  • [x] I have followed every step in the contributing guide
  • [x] The PR title follows the convention.
  • [x] I ran and tested the code works

Testing

Ran e2e test suite and checked v3 catalog in dev mode. Ran deploy test with local setup.


Changelog

Stop using esbuild metaOutput imports to build bundle package.json. This can be done because :

  • Direct dependencies metadata (version, external) is now collected before bundling since #1208
  • The previous way was to look for all bundle seen imports inside those direct dependencies
  • The fallback to a package.json dependencies then devDependencies then CLI dependencies check has been kept

Screenshots

[Screenshots]

💯

codenem avatar Jul 23 '24 12:07 codenem

🦋 Changeset detected

Latest commit: 3ed65ba32947b47dc1d52e92e6a31237bdc9735d

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Jul 23 '24 12:07 changeset-bot[bot]

@ericallam I'm closing this because I know you used it as inspiration for your larger rewrite of the CLI bundling

matt-aitken avatar Sep 18 '24 11:09 matt-aitken