LaravelPrometheusExporter icon indicating copy to clipboard operation
LaravelPrometheusExporter copied to clipboard

don't disrupt response on exception

Open ahmadalli opened this issue 5 years ago • 2 comments

this fixes #18

ahmadalli avatar May 16 '20 08:05 ahmadalli

Codecov Report

Merging #19 into master will decrease coverage by 1.18%. The diff coverage is 75.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #19      +/-   ##
============================================
- Coverage     94.93%   93.75%   -1.19%     
- Complexity       44       45       +1     
============================================
  Files             6        6              
  Lines           158      160       +2     
============================================
  Hits            150      150              
- Misses            8       10       +2     
Impacted Files Coverage Δ Complexity Δ
src/Middleware/RequestPerRoute.php 94.59% <75.00%> (-5.41%) 6.00 <0.00> (+1.00) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4dfb62f...a59d0e6. Read the comment docs.

codecov-io avatar May 16 '20 08:05 codecov-io

Pull Request Test Coverage Report for Build 133

  • 6 of 8 (75.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-1.3%) to 94.702%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Middleware/RequestPerRoute.php 6 8 75.0%
<!-- Total: 6 8
Totals Coverage Status
Change from base Build 131: -1.3%
Covered Lines: 143
Relevant Lines: 151

💛 - Coveralls

coveralls avatar May 16 '20 08:05 coveralls