barekit icon indicating copy to clipboard operation
barekit copied to clipboard

Modal trigger <a> with some <img> or <div> in it breaks Modal : it won't open

Open LeoFlandin opened this issue 11 years ago • 0 comments

<a href="#" class="modal-trigger" data-options='{ "modalId": "example-modal" }'>
    <img src="http://placehold.it/50x50">
    <span>Boom !</span>
</a>

<div class="modal" id="example-modal">
    <a href="#" class="modal-close right">X</a>
    <p>This is a modal</p>
    <p>This is a modal</p>
    <p>This is a modal</p>
    <p>This is a modal</p>
</div>

Javascript error : Uncaught TypeError: Cannot read property 'modalId' of undefined barekit.js:225

dirty fix line 225 : $(e.target).closest('.modal-trigger').data("options").modalId instead of $(e.target).data("options").modalId

LeoFlandin avatar Nov 04 '14 18:11 LeoFlandin