cloudone-filestorage-plugins icon indicating copy to clipboard operation
cloudone-filestorage-plugins copied to clipboard

feat(post-scan action): Create terraform version for the aws-slack-plugin

Open felipecosta09 opened this issue 3 years ago • 1 comments

Terraform version for the aws-slack-plugin

Change Summary

Add terraform template to deploy the plugin

PR Checklist

  • [X] I've read and followed the Contributing Guide.
  • Documents/Readmes
    • [X] Updated accordingly
    • [ ] Not required
  • Plugins that have versioning

felipecosta09 avatar Oct 10 '22 17:10 felipecosta09

Thanks a lot, @davidblanchard123 for the reviews and suggestions! Always very helpful. 🥇

felipecosta09 avatar Oct 19 '22 21:10 felipecosta09

LGTM. Please squash the commits.

trend-kwan-su avatar Nov 08 '22 07:11 trend-kwan-su

LGTM. Please squash the commits.

Hi @kwan-su There is an automated squash option in the PR, please refer to the Issue 94

felipecosta09 avatar Nov 08 '22 16:11 felipecosta09

@felipecosta09 Reviewed. Please test the template after the code changes, thanks!

trend-kwan-su avatar Nov 15 '22 02:11 trend-kwan-su

@felipecosta09 Please check all the naming of variables are correct and let me know if the template is tested then we can approve this PR to merge.

trend-kwan-su avatar Nov 16 '22 01:11 trend-kwan-su

@felipecosta09 Seem like there are variable declaration issues.

image

JimLin94 avatar Nov 25 '22 09:11 JimLin94

@felipecosta09 Seem like there are variable declaration issues.

image

That should be fixed @JimLin94

felipecosta09 avatar Apr 11 '23 16:04 felipecosta09