tree-sitter-python icon indicating copy to clipboard operation
tree-sitter-python copied to clipboard

fix: escape the ‘#’ in Makefile

Open yejunjin opened this issue 1 year ago • 1 comments

Compile using Makefile emit error:

Makefile:41: *** unterminated call to function 'shell': missing ')'.  Stop

It looks like the '#' and its following content are parsed into a comment. Escape it works good.

yejunjin avatar Sep 23 '24 09:09 yejunjin

I can't replicate your error - what's your os and shell

amaanq avatar Sep 25 '24 23:09 amaanq

@amaanq Here is my os, shell and make versions os: centos7 shell: bash 4.2 make: 3.82 I think it is relevant to make version but not os and shell, since the make command parse it as a comment

yejunjin avatar Nov 28 '24 03:11 yejunjin

Make 3.82 is over 14 years old...sorry.

amaanq avatar Nov 28 '24 04:11 amaanq

It's been fixed anyway.

ObserverOfTime avatar Nov 28 '24 15:11 ObserverOfTime

Why does not merge my PR, rather than coding again? It is not friendly to open source contributer, right ? https://github.com/tree-sitter/tree-sitter-python/blame/409b5d671eb0ea4972eeacaaca24bbec1acf79b1/Makefile#L30

yejunjin avatar Jan 13 '25 03:01 yejunjin

Because this was fixed upstream.

ObserverOfTime avatar Jan 13 '25 05:01 ObserverOfTime

Because this was fixed upstream.

All right. Could you tell me in which upstream the fix was introduced?

yejunjin avatar Jan 13 '25 07:01 yejunjin

https://github.com/tree-sitter/tree-sitter/commit/939e61c58de00342d4fd56df7a1c60948a03ca3f#diff-a4bf7a6873d0730efad02c1acf3ec3e8b98d053b4f03ae0e4a72e2081e4dfd8dR30

ObserverOfTime avatar Jan 13 '25 09:01 ObserverOfTime