digdag Reopen "get k8s config from requestConfig. and added test."

I rebased this PR(#1279) from master. Please review.

Jan 17 '22 06:01 hnarimiya

IIUC, this PR will allow to configure K8 in workflow definition ? If so, I would like to ask you to add server configuration to enable/disable of it and default is disable for server administrators.

Apr 15 '22 01:04 yoyama

@yoyama Sorry for late reply.

I'm sorry if it's not what I intended.

I would like to add a parameter that allows setting using the parameter of "kubernetes" from the workflow. The parameters are as follows.

agent.command_executor.kubernetes.allow_configure_workflow_definition=true

If this parameter is true, requestConfig is merged with systemConfig and used like PR.

If false, only systemConfig is used. (As an image, the original createFromSystemConfig method)

If this parameter is not set or defaults, it is treated as false.

Jul 06 '22 04:07 hnarimiya

@yoyama Added parameter. https://github.com/treasure-data/digdag/pull/1692#issuecomment-1175773307

I don't know if this is intended by yoyama san, so please tell me your opinion.

I fixed it based on some indications in the code. https://github.com/treasure-data/digdag/pull/1692#discussion_r914495928 https://github.com/treasure-data/digdag/pull/1692#discussion_r914499547 https://github.com/treasure-data/digdag/pull/1692#discussion_r914501498

Please review.

Jul 06 '22 11:07 hnarimiya

@hnarimiya Could you rebase your PR to the latest master and fix the CI failures ?

Dec 23 '22 03:12 yoyama

@yoyama @szyn I'm sorry for being late. Please review.

Feb 05 '24 07:02 hnarimiya