The result of LIRS is not correct

Open sktzwhj opened this issue 8 years ago • 3 comments

Hi trauzti,

It seems your result of LIRS is not correct. If you just run the example given by the LIRS paper of Song Jiang, you will find your result is different from that shown in the paper.

Mar 01 '17 12:03 sktzwhj

Thanks @sktzwhj for reporting this issue. I have a better Python implementation written that I can hopefully find time to push to this repository soon.

Mar 06 '17 07:03 trauzti

Interesting thing is that I do my own implementation and it seems my result is the same as yours. But different from the one in the paper. It would be great if you can push that.

Mar 06 '17 07:03 sktzwhj

Try running the new LIRS_standalone.py program that I just commited. It is a more robust implementation but does not skip repeated references like the original program from the authors. This should work as expected on the example input from the paper. Let me know what happens.

Apr 01 '17 22:04 trauzti