t11s comments

Results 145 comments of


                                            t11s

Optimize merkle proof by having the arguments in calldata

but this seems like a really good change, 200 gas is sick

This implementation violates the invariant that the VRGDA should never reach 0

i dont think not reaching 0 is necessarily an invariant, whats the use case you have in mind where it needs to round up?

This implementation violates the invariant that the VRGDA should never reach 0

we have finite precision, beyond a certain point both rounding up and rounding down are "wrong" behavior mathematically

This implementation violates the invariant that the VRGDA should never reach 0

i am a little biased cuz its a bit scary changing things to differ from the gobbler implementation, but i do kinda agree with you specifically if you, say, wanted...

This implementation violates the invariant that the VRGDA should never reach 0

also iirc this led to some weird behavior in lower elos of monaco

This implementation violates the invariant that the VRGDA should never reach 0

@0xAlcibiades if you want to make a PR for this i think i'd be willing to merge it thru 👍

This implementation violates the invariant that the VRGDA should never reach 0

awesome

Move VRGDA logic into a lib

wait why close?

Move VRGDA logic into a lib

sorry my bad for not merging earlier

Move VRGDA logic into a lib

yes def, sorry i will clean this up asap and get it merged!