traitecoevo
Remove redis api in favour of redux
Codecov Report
:exclamation: No coverage uploaded for pull request base (
master@d0a23e5). Click here to learn what that means. The diff coverage is87.5%.
@@ Coverage Diff @@
## master #31 +/- ##
=========================================
Coverage ? 80.42%
=========================================
Files ? 22
Lines ? 1466
Branches ? 0
=========================================
Hits ? 1179
Misses ? 287
Partials ? 0
| Impacted Files | Coverage Δ | |
|---|---|---|
| R/task.R | 82.52% <ø> (ø) |
|
| R/heartbeat.R | 0% <ø> (ø) |
|
| R/redis.R | 68.42% <ø> (ø) |
|
| R/worker.R | 74.8% <0%> (ø) |
|
| R/common.R | 93.91% <100%> (ø) |
|
| R/object_cache.R | 100% <100%> (ø) |
|
| R/task_bundle.R | 95.69% <100%> (ø) |
|
| R/utils.R | 84.61% <100%> (ø) |
|
| R/queue.R | 77.55% <50%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update d0a23e5...bb01ad1. Read the comment docs.
Please try this @dfalster, and if it works approve and merge the PR.
Depending on how you are using the package, it will probably be quite simple to move over to rrq, which splits apart some of the things going on in this package. If this basically works for you, don't stress and just keep as-is, but if you're getting weird behaviour, switching will be easier than ferreting the behaviour out of this package!
Note that this changeset removes the heartbeat entirely as I can't get the old version to compile on travis, and if you can't get the new version going that's no good either
Thanks very much for taking a look and suggestions @richfitz
I won't get to it this week and then go on school holidays for 2 weeks, so you can expect a follow up in late Oct / early Nov.
