CalendarListview icon indicating copy to clipboard operation
CalendarListview copied to clipboard

setmController should be renamed setController

Open apkelly opened this issue 11 years ago • 3 comments

This may just be a personal preference, but I think the method setmController should be renamed to remove the "m".

apkelly avatar Nov 12 '14 12:11 apkelly

+1

eeVoskos avatar Dec 19 '14 11:12 eeVoskos

No preference, just adding that Android Studio sees "setm" and the sample MainActivity.java shows "set".

Somewhere I followed the doc that includes: compile 'com.github.traex.calendarlistview:library:1.2.2' so that breaks setmController / setController, omits the abstract class for date range, and app:attributes didn't work.

When I noticed the version change, I updated to calendarview 1.2.3, Android Studio wouldn't build. The new requirement is CompileSDK version 21 (I was at 19 because when 21 came out attempting to use it broke existing AS projects). This fixes the setm..., abstract class and app:attributes issues.

Hope this helps someone.

ksasly avatar Dec 30 '14 22:12 ksasly

+1

brunocascio avatar Feb 03 '15 21:02 brunocascio