trac-hacks
Use Font Awesome to provide a cute icon
Another little patch from my instance of the plugin. Adds the GitHub icon next to the "GitHub Login" link to better distinguish it, and make clearer that it will send users to GH.
Something to consider is whether we want to include the Font Awesome script in the plugin (see ITemplateProvider) so that it can be served directly. If we choose to not do that, it could still be served directly by adding the script to the Environment or shared htdocs directory and using a path starting with /chrome/site/.
I'd rather not add several hundred kilobytes of Font Awesome to every page for loading a single icon.
Can we load only the icon we need, one way or another?
@rjollos @aaugustin I've thought about both these things. I definitely agree FA is overkill, it was just the quickest and easiest way to do this. What I do like about it is that it's an actual font glyph and scales with the text nicely, but I've heard of ways to extract just the bits you need out of FA. I could look into that.
For my purposes it was fine, but I agree with these points.
Good point by @aaugustin. Assuming we can use a smaller script, I think it would be reasonable to bundle the script in the plugin and remove the option. If someone really dislikes the icon they can customize their interface to remove it.
http://fontello.com/ make is super easy to build a custom subset of Font Awesome — in that case, a subset with only the icon you need.
