trac-code-comments-plugin icon indicating copy to clipboard operation
trac-code-comments-plugin copied to clipboard

Problem when doing comments for revision diffs

Open walty8 opened this issue 7 years ago • 1 comments

In a revision diff page, with a customised 'from' and 'to' revisions (as we normally batch review a range of changesets), I could still make comments there. However, there are two problems:

  1. the link in the comments page does not get me back to the diff page, instead, it bring me to the latest changeset regarding to the 'to' revision.

  2. the comments in the page have wrong positions.

It seems to be related with the following code in web.py

    def changeset_js_data(self, req, data):
        return {
            'page': 'changeset',
            'revision': data['new_rev'],
            'path': data['reponame'],
            'selectorToInsertAfter': 'div.diff div.diff:last'
        }

Apparently, only the reponame, and last revision is stored, instead of the actual diff. I wonder if it would be possible if the full browser URL is stored inside the 'path' column instead?

walty8 avatar Nov 12 '18 16:11 walty8

Is this a duplicate of #67?

SebDieBln avatar Aug 28 '23 22:08 SebDieBln