Add HSL.

Open Ferada opened this issue 12 years ago • 3 comments

Hi, I've resurrected my fork and prepared this one (of two) pull requests. It adds HSL colors and conversions to RGB and, via a default method, to all others. Also two helper methods to lighten/darken a color.

Feb 15 '14 23:02 Ferada

Hi, thanks for the contribution, I definitely want to apply it. However, can you please add some tests? Doing a few colors conversions with reliable software (eg gimp) and checking these in tests would be great.

Feb 16 '14 09:02 tpapp

On it. It seems I've also missed a few places from the previous version, so I'll check in corrections and some tests later.

Btw. have you seen https://github.com/ralph-schleicher/rs-colors?

Feb 16 '14 14:02 Ferada

Okay, it seems all tests run through from a clean state. There are two colors I've checked with GIMP and another tool, the rest are automatic checks.

Feb 16 '14 15:02 Ferada