Prass icon indicating copy to clipboard operation
Prass copied to clipboard

Lines overlapping in certain keyframe situations

Open Gebbi opened this issue 8 years ago • 1 comments

When using scenetiming and linking together, lines will overlap in this situation:

[Line1]....... [Line2]..|KF|..... [Line3]

--> Linking [Line1].......[Line2]..|KF|.....[Line3]

--> Scenetiming [Line1].......[Line2 + Line1-Overlap]..|KF + Line1-End|.....[Line3]

According to subs.py linking happens before scenetiming, which should be the source for this behavior. Simply switching both seems to fix it, but might have other implications though.

Example SRT:

1
00:21:51,920 --> 00:21:54,631
Line 1

2
00:21:54,798 --> 00:21:57,259
Line 2 (snaps to keyframe)

3
00:21:57,425 --> 00:22:01,805
Line 3 (overlaps to line 2 due to previous linking)

4
00:22:01,930 --> 00:22:06,685
Line 4

Example keyframes:

example_keyframes.txt

Gebbi avatar Apr 24 '17 20:04 Gebbi

Note: --kf-after-end has to be at least 300 for the problem to trigger in this example case.

Gebbi avatar May 05 '17 21:05 Gebbi