SQLiter

SQLiter copied to clipboard

Fix multithreaded test

1

This test is failing for DELETE journal, but it was probably written for WAL specifically. https://github.com/touchlab/SQLiter/blob/main/sqliter-driver/src/nativeCommonTest/kotlin/co/touchlab/sqliter/NativeDatabaseConnectionTest.kt#L32

kpgalligan

The public and internal apis aren't well defined. There's a whole lot that could be made internal or private. A good example would be `SqliteDatabase`

kpgalligan

Just a tracking issue

JakeWharton

Basically, the logic tries to strip out the slases, but also results in extra characters on the end. Should decide if we support URL syntax at all, and possibly replace...

kpgalligan

Revisit "File"

1

The file handling could use a clean up.

kpgalligan

Use sqlite amalgamation for compatibility

3

I propose to use the sqlite amalgamation (https://www.sqlite.org/amalgamation.html) rather than linking the `libsqlite3` library which is installed on the host. This has several advantages: - It is more portable: -...

chippmann

`migrateIfNeeded()` and multiple processes

3

The `PRAMGA user_version` read for determining need of creation & migration is not part of the subsequent write transaction. It seems to be a plausible race condition, which multiple processes...

andersio

`ConcurrentDatabaseConnection` and its NSRecursiveLock

1

`ConcurrentDatabaseConnection` at the moment uses a NSRecursiveLock, which is kinda emulating the SQLite Serialized mode, i.e., open with flag `SQLITE_OPEN_FULLMUTEX`. Meanwhile, the SQLite3 distribution on Darwin platforms [has long been...

andersio

Added a verbose logger for the statement, but need to write some tests on it. May ultimately not support that, as I'm not sure of its real utility.

kpgalligan

Need some kind of tests around error message production from exceptions

kpgalligan