CrashKiOS icon indicating copy to clipboard operation
CrashKiOS copied to clipboard

Tk/dynamic crashlytics

Open TadeasKriz opened this issue 1 year ago • 1 comments

I've replaced direct usage of Firebase Crashlytics ObjC classes with dynamic calls. This way stripped symbols are no longer a problem. The one symbol we still need to mark as "unresolved" (_FIRCLSExceptionRecordNSException) is available even after symbols are stripped. That means dyld is able to link it in runtime.

I've also made it into a weak symbol to improve the error message when we try to use it, but it's not available.

TadeasKriz avatar Jun 27 '24 02:06 TadeasKriz

@TadeasKriz Hello! Can we have a pre-release (alpha01 or something) so we can help with testing? I have a large dynamic framework which might trigger other side effects

tamimattafi avatar Jun 28 '24 08:06 tamimattafi

Hello @TadeasKriz thanks for this fix!

Do you know if there is a timeline on when we could expect this to be merged and fixed?

JackHurst0 avatar Aug 05 '24 07:08 JackHurst0

Sorry all. Review was on me and I've been super busy. Diving in...

kpgalligan avatar Aug 13 '24 13:08 kpgalligan

Thanks once again for this fix @TadeasKriz

Just like @tamimattafi said, if you need real projects to test a pre-release, I can try to make some time to help with that.

JackHurst0 avatar Aug 16 '24 17:08 JackHurst0