FiraCode icon indicating copy to clipboard operation
FiraCode copied to clipboard

Pipe-Bracket and Pipe-Brace ligatures are confusing {| [| |] |}

Open kiprobinson opened this issue 7 years ago • 12 comments

Ligatures for pipe-bracket and pipe-brace combination are confusing. They appear to turn the pipe into a square bracket. This is especially pronounced in bold.

What I mean is:

  • {| looks like: {[
  • [| looks like: [[
  • |} looks like: ]}
  • |] looks like: ]]

Here are screenshots of the markdown for above:

screenshot-normal

screenshot-bold

kiprobinson avatar Aug 22 '18 18:08 kiprobinson

Hmm. Maybe you’re right

tonsky avatar Aug 23 '18 09:08 tonsky

Maybe something more like this?

image

kiprobinson avatar Aug 23 '18 15:08 kiprobinson

Perhaps don’t extend the horizontal lines of the {[]} past the |?

j-f1 avatar Aug 23 '18 16:08 j-f1

IMHO it's now even more confusing than before. Can't recognize whether it's a closing or opening brace. Both are looking on LCD monitor like a box: image image

Actually I liked the previous version much more. Very subjective, but maybe this were better? https://github.com/tonsky/FiraCode/issues/643#issuecomment-415459368

vilinski avatar Oct 05 '18 09:10 vilinski

Yeah thx @vilinski I agree it’s confusing now

tonsky avatar Oct 05 '18 09:10 tonsky

Is it possible to revert this change? The previous versions were much clearer and I never had any trouble distinguishing [[ from [| etc. because the spacing between vertical bars was distinct enough - these new glyphs just look like really bad kerning :/

yuhan0 avatar Jan 31 '19 20:01 yuhan0

Not right now. Maybe eventually we’ll let everyone to configure their own font

tonsky avatar Jan 31 '19 22:01 tonsky

In Ruby it's common to write list.each do {|item| puts item} and {| ends up looking pretty wonky.

Wondering what we can do to improve this?

ioquatix avatar Mar 22 '19 07:03 ioquatix

Gotta remove it then. Thanks!

On Fri, Mar 22, 2019 at 10:26 AM Samuel Williams [email protected] wrote:

In Ruby it's common to write "list.each do {|item| puts item}and{|` ends up looking pretty wonky.

Wondering what we can do to improve this?

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/tonsky/FiraCode/issues/643#issuecomment-475519547, or mute the thread https://github.com/notifications/unsubscribe-auth/AARabHJPdjSyQlwFSjLBt4Tvm089UsiRks5vZIWqgaJpZM4WIJ_t .

tonsky avatar Mar 24 '19 14:03 tonsky

@tonsky Do you mean I should remove it (and rebuild a local version of the font) or do you mean we should remove it from the font in general?

ioquatix avatar Mar 24 '19 21:03 ioquatix

Sorry for ambiguity. I will remove those in the next Fira Code version On Mon, 25 Mar 2019 at 00:28, Samuel Williams [email protected] wrote:

@tonsky https://github.com/tonsky Do you mean I should remove it (and rebuild a local version of the font) or do you mean we should remove it from the font in general?

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/tonsky/FiraCode/issues/643#issuecomment-476002020, or mute the thread https://github.com/notifications/unsubscribe-auth/AARabFTS6n_hoRbHPe5wUc3tWLisolO0ks5vZ-4SgaJpZM4WIJ_t .

tonsky avatar Mar 25 '19 10:03 tonsky

In Ruby it's common to write list.each do {|item| puts item} and {| ends up looking pretty wonky.

Wondering what we can do to improve this?

have same issue with reading own ruby code {| looks funny :)

But I am guessing there is no ideal solution, shape.

nikolaiderzhak avatar Nov 10 '23 14:11 nikolaiderzhak