FiraCode icon indicating copy to clipboard operation
FiraCode copied to clipboard

Added � and ⚠

Open gjvnq opened this issue 5 years ago • 6 comments

gjvnq avatar Dec 24 '20 19:12 gjvnq

Wow, thanks. But

75,971 additions, 73,603 deletions

Not sure how to merge this. Also

- .appVersion = "1348";
+ .appVersion = "3039";
+ .formatVersion = 3;

I haven’t bought the new version yet (not sure if will).

Any way you can isolate just the outlines? Would be happy to merge those

tonsky avatar Dec 28 '20 00:12 tonsky

I will see what I can do. I had tried to save on the old version format but the app kept complaining about something not being compatible.

Gabriel Queiroz

On Sun, 27 Dec 2020 at 21:29, Nikita Prokopov [email protected] wrote:

Wow, thanks. But

75,971 additions, 73,603 deletions

Not sure how to merge this. Also

  • .appVersion = "1348";
  • .appVersion = "3039";

  • .formatVersion = 3;

I haven’t bought the new version yet (not sure if will).

Any way you can isolate just the outlines? Would be happy to merge those

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/tonsky/FiraCode/pull/1175#issuecomment-751534765, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAXIYHCQQW2UVAEIQDDEOXTSW7GN3ANCNFSM4VIPGVHQ .

gjvnq avatar Dec 29 '20 00:12 gjvnq

I redid my work and I hope it can now work on the old version of the app.

gjvnq avatar Dec 29 '20 02:12 gjvnq

Thank you, I merged U+FFFD as a755aabbce0f7aa5ba82ffab57157f682b790638.

About ⚠, I am not sure: I don’t like how it looks. Maybe base it on equilateral triangle?

This is how it looks in your PR:

Screenshot 2020-12-29 at 18 36 57 Screenshot 2020-12-29 at 18 37 02

These are some other characters from the font that look more fira code-like.

Screenshot 2020-12-29 at 18 37 13 Screenshot 2020-12-29 at 18 37 45 Screenshot 2020-12-29 at 18 38 13

I also feel that line width should match stem width.

tonsky avatar Dec 29 '20 17:12 tonsky

The actual commit is 415c773d6aa8631f3643cb59ecc79e97090d370f (forgot to update CHANGELOG.md)

tonsky avatar Dec 29 '20 17:12 tonsky

Ty

itsMo07 avatar Mar 04 '21 04:03 itsMo07