nest-manager icon indicating copy to clipboard operation
nest-manager copied to clipboard

No clientID, clientSecret fields in Settings section

Open Rob-ee opened this issue 7 years ago • 16 comments

Verify the following before opening an issue:

  • [X] You followed the Nest Developer documentation here? Nest Developer Account Creation
  • [X] That OAuth is Enabled for the SmartApp under the IDE.
  • [X] The SmartApps and ALL (5) Devices Handlers are using the latest code available.
  • [X] You have reviewed the NST Manager Wiki for potential fixes.
  • [X] That ALL SmartApps and Device Handlers have been Published for You in the IDE.

About Your Setup:

  • How many Thermostats?: 1
  • How many Protects? 0
  • How many Cameras? 0
  • Using the Nest Presence Device? 1
  • Using the Nest Weather Device? 1
  • iOS or Android?: Android
  • Mobile App Version:

Expected Behavior

In ST IDE, for Nest Manager SmartApp, according to PDF , there should be clientID & ClientSecret fields under "Settings" section

Current Behavior

There are no fields under "Settings" section, just text "Add setting definitions in the source code and then set the values here"

Steps to Reproduce (for bugs)

  1. Installed Nest manager via auto ST Community installer
  2. Followed instructions in https://rawgit.com/tonesto7/nest-manager/master/Documents/instructions/Nest%20Developer%20-%20Nest%20Product.pdf and created NEST dev account, copied Product ID, Product Secret to clipboard
  3. Opened the "Settings" section of Nest Manager SmartApp, but there are no fields, just a message "Add setting definitions in the source code and then set the values here"

Context

Rob-ee avatar Feb 17 '18 18:02 Rob-ee

Ran into the same issue myself. Installed via ST Community installer as well.

Watso4183 avatar Mar 05 '18 13:03 Watso4183

Did this ever get solved? Ive ran into the same issue myself.

MarkToon avatar Mar 24 '18 18:03 MarkToon

+1. I'm having the same issue.

safetymonkey avatar Mar 28 '18 17:03 safetymonkey

I was playing around with it and honestly I can't remember exactly what I did to resolve it, but I think it had something to do with manually downloading each script and running it, I think that I figured out that the bundled installer was a bit different than the last version

On 28.3.2018. 19:17, safetymonkey wrote:

+1. I'm having the same issue.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/tonesto7/nest-manager/issues/553#issuecomment-376965537, or mute the thread https://github.com/notifications/unsubscribe-auth/AIcWcr3ZMZgeeWUJLuTHJnNOZMHXWbVYks5ti8WZgaJpZM4SJazz.

Rob-ee avatar Mar 28 '18 17:03 Rob-ee

Well, sure. The problem doesn't exist if I download the raw versions of the scripts and input them in the IDE directly. But this bug relates specifically to the app installer, which is listed as the "strongly recommended" option. :)

On Wed, Mar 28, 2018 at 10:57 AM, Rob-ee [email protected] wrote:

I was playing around with it and honestly I can't remember exactly what I did to resolve it, but I think it had something to do with manually downloading each script and running it, I think that I figured out that the bundled installer was a bit different than the last version

On 28.3.2018. 19:17, safetymonkey wrote:

+1. I'm having the same issue.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <https://github.com/tonesto7/nest-manager/issues/553# issuecomment-376965537>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ AIcWcr3ZMZgeeWUJLuTHJnNOZMHXWbVYks5ti8WZgaJpZM4SJazz>.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/tonesto7/nest-manager/issues/553#issuecomment-376978625, or mute the thread https://github.com/notifications/unsubscribe-auth/AALeCIG1GifUAxO2ZCV-3fFY0poNvIASks5ti88kgaJpZM4SJazz .

safetymonkey avatar Mar 28 '18 18:03 safetymonkey

+1, same issue

ramginuga avatar Apr 05 '18 15:04 ramginuga

+1 As a new ST user this is my first community installed smart app, following the "Strongly recommended" option.

cdevereu avatar Apr 06 '18 11:04 cdevereu

I resolved this by clicking "code" in the right corner in the IDE then Clicking save. That seemed to have triggered the IDE to re-digest the definitions.

bbuchan10 avatar Apr 06 '18 16:04 bbuchan10

I also resolved this by manually copying/pasting the Nest Manager raw code from Github (https://github.com/tonesto7/nest-manager/blob/master/smartapps/tonesto7/nest-manager.src/nest-manager.groovy) over the top of the existing code put there by the community installer. Save > Publish then the settings appeared

cdevereu avatar Apr 06 '18 16:04 cdevereu

Again, copying the code defeats the purpose of the recommended installation method. I can and have copied the code over, but this is a bug with the recommended solution.

On Fri, Apr 6, 2018 at 9:49 AM, Chris Devereux [email protected] wrote:

I also resolved this by manually copying/pasting the Nest Manager raw code from Github (https://github.com/tonesto7/nest-manager/blob/master/ smartapps/tonesto7/nest-manager.src/nest-manager.groovy) over the top of the existing code put there by the community installer.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/tonesto7/nest-manager/issues/553#issuecomment-379311334, or mute the thread https://github.com/notifications/unsubscribe-auth/AALeCPRmPSmwunbFjxdUMeTQ31glUmuUks5tl5x-gaJpZM4SJazz .

safetymonkey avatar Apr 06 '18 16:04 safetymonkey

I do not believe it is an issue with the automated installation. As the definitions for the fields are in the code. Just simply saving the code again, not pasting over it(that is extra work), resolves the issue. I believe it is an issue with the IDE ingesting the definition the first time.

bbuchan10 avatar Apr 06 '18 17:04 bbuchan10

Then the instructions should probably be updated to note this workaround.

On Fri, Apr 6, 2018 at 10:01 AM, bbuchan10 [email protected] wrote:

I do not believe it is an issue with the automated installation. As the definitions for the fields are in the code. Just simply saving the code again, not pasting over it, resolves the issue. I believe it is an issue with the IDE ingesting the definition the first time.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/tonesto7/nest-manager/issues/553#issuecomment-379314767, or mute the thread https://github.com/notifications/unsubscribe-auth/AALeCEOC7o1ew5-QDK_BiLowFigWbV4Wks5tl593gaJpZM4SJazz .

safetymonkey avatar Apr 06 '18 19:04 safetymonkey

Same issue here. I can confirm going into code and hitting 'save' did the trick. A note in the Wiki would be helpful.

bugzc avatar Apr 12 '18 05:04 bugzc

Had the same issue as everyone else above and going to the code and hitting "save" worked for me as well. I agree with bugzc

automate2win avatar May 20 '18 04:05 automate2win

Yes - agree the guide for creating your own nest dev id (https://rawgit.com/tonesto7/nest-manager/master/Documents/instructions/Nest%20Developer%20-%20Nest%20Product.pdf) needs to be updated to mention quickly saving the code in IDE to allow the settings to refresh, wasted a few mins on this myself.

VTChevalier avatar May 29 '18 21:05 VTChevalier

@cdevereu Your solution worked for me. I did a faked an upgrade and republish. Settings appeared and it was fine.

dcurrie1961 avatar Jul 06 '18 21:07 dcurrie1961