TZStackView icon indicating copy to clipboard operation
TZStackView copied to clipboard

Add support for tvOS

Open nuudles opened this issue 10 years ago • 12 comments

I needed a UIStackView in some shared code between my tvOS app and an iOS app, so I've gone ahead and added tvOS podspec support for TZStackView and it seems to work great.

nuudles avatar Oct 19 '15 22:10 nuudles

@tomvanzummeren is there any reason for not merging this PR?

iGranDav avatar Feb 16 '16 13:02 iGranDav

Not really, other than I have no time right now to process the whole list of merge requests for TZStackView and release a new cocoapods version etc.

tomvanzummeren avatar Feb 16 '16 13:02 tomvanzummeren

Ok do not hesitate to provide contributor rights if you need help to maintain and test this great library.

iGranDav avatar Feb 16 '16 15:02 iGranDav

Hey @iGranDav , would you really like to help me maintain this library? I can give you contributor rights if you're still interested!

tomvanzummeren avatar Feb 24 '16 19:02 tomvanzummeren

Hello @tomvanzummeren I would be happy to test and merge some PR but I have strongly limited ressources to test under iOS 7

iGranDav avatar Feb 25 '16 08:02 iGranDav

@iGranDav well, thanks to one of the pull requests I merged in the past, the library is no longer compatible with iOS 7 anyway. So you would not be making things worse.

But isn't iOS 7 available anymore as a Simulator?

tomvanzummeren avatar Feb 25 '16 08:02 tomvanzummeren

@tomvanzummeren not really supported officially and you need to have Xcode 6.4. But in any case it doesn't work that way because you will be then building under SDK 8. And we want to test on iOS 7 with a SDK 9 build.

iGranDav avatar Feb 25 '16 08:02 iGranDav

@iGranDav ok I agree, so it won't be a 100% covering test if you test with SDK 8. But it will be a lot better than NOT doing any testing, right?

Best case scenario: you end up restoring iOS 7 support Worst case scenario: everything stays the same (no support for iOS 7)

Are you up for it?

tomvanzummeren avatar Feb 25 '16 08:02 tomvanzummeren

Let's do this :+1:

iGranDav avatar Feb 25 '16 08:02 iGranDav

I made you a collaborator!

tomvanzummeren avatar Feb 25 '16 08:02 tomvanzummeren

Thanks! I'll be merging this tested one first :)

iGranDav avatar Feb 25 '16 08:02 iGranDav

aight! good luck!

tomvanzummeren avatar Feb 25 '16 08:02 tomvanzummeren