set outline of focus on 1 instead of 0

Open jmslbam opened this issue 5 years ago • 2 comments

The line https://github.com/tomusborne/generatepress/blob/7b35168f546f83a7abb098a8da3bc0674d49ddeb/sass/components/_links.scss#L25-L33 stop my textarea from getting an outline when focussed on.

Also remove this without a proper replacement is against A11Y best-practices https://www.a11yproject.com/posts/2013-01-25-never-remove-css-outlines/

Mar 26 '21 15:03 jmslbam

Ah and also the select input etc

Mar 26 '21 16:03 jmslbam

Thanks for this! I wonder if the outline is necessary for these elements since they have a border change that indicates that they're focused?

Everything should still have an outline if tabbed, but clicking we do remove it for aesthetics (could probably use some discussion to see if that's even necessary anymore).

Jun 23 '21 16:06 tomusborne