tinycon icon indicating copy to clipboard operation
tinycon copied to clipboard
verified publisher icon tommoor

Update drawFavicon to be compatible with Chrome

Open nzh opened this issue 7 years ago • 5 comments

This immediately calls the onload function after it is defined, to ensure that changes are picked up.

nzh avatar Oct 31 '18 23:10 nzh

Great PR - fixes the Chrome issue: https://github.com/tommoor/tinycon/issues/96

but you have a typo: uload instead of onload

adrianbj avatar Jan 31 '19 18:01 adrianbj

fixed

nzh avatar Feb 01 '19 00:02 nzh

👋 I don't understand what this achieves, calling the onload before the src is defined. Could one of you speak to the solution?

tommoor avatar Feb 03 '19 07:02 tommoor

@tommoor - I honestly haven't looked into why this works, but the key thing in my setup that causes the problem with Chrome seems to be the presence of:

<link rel="apple-touch-icon" sizes="180x180" href="/apple-touch-icon.png">

Chrome (on MacOS) is actually using this icon instead of the standard favicon.ico or any of the transparent png versions created by https://realfavicongenerator.net/ or one of those other services. It's actually quiet annoying because the apple icon isn't transparent. If I remove the link to the apple icon tinycon works without this fix, but if I want the apple icon, this fix works.

adrianbj avatar Feb 03 '19 13:02 adrianbj

Tinycon broke for us as well and this PR fixes it.

brenc avatar Apr 11 '20 22:04 brenc