vim-code-dark icon indicating copy to clipboard operation
vim-code-dark copied to clipboard

Some colors don't match with the original VSCode theme

Open ndavidpsi opened this issue 5 years ago • 5 comments

Hi, thanks for the colorscheme, it's my favorite and the one I have been using for the past couple of months.

But one thing caught my attention, the color of functions, imports, classes, etc is usually blue and not purple in the original colorscheme. Would it be possible to change those or was it intentional?

ndavidpsi avatar Dec 28 '20 22:12 ndavidpsi

Hi! Thank you for your comment.

In my opinion, the biggest difference is caused by the fact that VSCode uses a different strategy to parse the source codes and different highlight categories. In Vim, the basic parsing is very simple and you usually need to install more advanced plugins.

Throughout the life of vim-code-dark, a lot of people have contributed with more accurate color definitions. If you look at the codedark.vim file, for example at the JavaScript section, you will see that jsFuncArgs, jsClassDefinition, etc. use a blue color, not purple (pink). However, this depends on how your Vim and your plugins parse your JavaScript code, and it works the same for all other languages.

If you are not a fan of the purple (pink) color, you can try using the conservative mode (let g:codedark_conservative = 1) that replaces pink by blue.

tomasiser avatar Jan 08 '21 10:01 tomasiser

Thank you for the explanation :) it's my favorite colorscheme, I have tried others but I always end up going back to this one (I like to change the background color to black, it looks really nice that way as well).

I use treesitter highlighting which helps. But what I meant was something more like the gruvbox-material theme where there are two different colors for example let and set in vimscript not removing the pink color just adding a few more. Maybe even create a new more colorful mode who knows :D

ndavd avatar Jan 08 '21 10:01 ndavd

Things are MUCH better with treesitter and https://github.com/tomasiser/vim-code-dark/pull/79

David-Else avatar Apr 07 '21 11:04 David-Else

@tomasiser May I suggest you add this theme to https://github.com/rockerBOO/awesome-neovim#treesitter-supported-colorschemes now that it is treesitter compatible.

David-Else avatar Apr 14 '21 13:04 David-Else