react-native-echarts-wrapper icon indicating copy to clipboard operation
react-native-echarts-wrapper copied to clipboard

toString is broken when enable Hermes

Open chj-damon opened this issue 5 years ago • 5 comments

https://github.com/facebook/hermes/issues/288

any idea that maybe we can convert toString() to pure javascript string?

chj-damon avatar Aug 05 '20 03:08 chj-damon

@chj-damon Thank you for pointing this out. I think there is a way to fix this. I will provide further information in the future.

tomLadder avatar Oct 08 '20 18:10 tomLadder

@tomLadder are you making some progress now?

chj-damon avatar Jan 25 '21 08:01 chj-damon

@chj-damon Thank you for pointing this out. I think there is a way to fix this. I will provide further information in the future.

any update on this? thanks

this info may be helpful https://github.com/facebook/hermes/commit/0ee971d1dffd28882a15034d803afe5f2ab439d7

surethink avatar Jul 11 '21 05:07 surethink

@surethink try this: https://github.com/thundersdata-frontend/td-design/tree/master/packages/react-native-echarts it works with or without hermes.

chj-damon avatar Jul 11 '21 08:07 chj-damon

@tomLadder are you making some progress now? 最近也在追查 funtion.toString() 的问题, 佩服妹子锲而不舍的精神, 赞赞赞!哈哈。。。。

weishengkui avatar Sep 25 '22 14:09 weishengkui