Could uploadDDSLevels take a view instead of a buffer?

Open areinot opened this issue 13 years ago • 1 comments

Great tools! I've only tried out the DDS loader so far and I'm already a fan. If I were to make a suggestion, could uploadDDSLevels() take as its data input, a typed-array view instead of an ArrayBuffer?

I am pulling my DDS'es from a big blob of binary data and need to give uploadDDS a subsection of my full ArrayBuffer. Views are easy to slice and dice on the go but ArrayBuffer slicing copies data around (afaik). I've stopped passing around ArrayBuffers all together for this very reason. Feels kind of like using void*, you know?

Jun 13 '12 08:06 areinot

This is a good point, actually! I hadn't really thought about it, but breaking the buffer up into smaller views is fundamentally different between the two types. (That's a shame, really. I'm not sure why new Int32Array(someView, 12, 24) wouldn't work.)

I'll see if I can whip up a version that gets a UInt8Array view of the entire buffer/view, which should work identically in both cases, and then uses subarray to get the subsequent views instead. Hopefully that will cover anything that the users throw at it.

Jun 14 '12 20:06 toji